feat: Support linting complex udim2 constructors that can be simplified #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a common PR comment and one that reduces readability. A selene lint to check for this usage will speed up development.
chriscerie
requested changes
May 23, 2024
|
Can you update changelog too? @Quenty |
|
Updated the changelog! |
chriscerie
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Last change, can you also update https://github.com/Kampfkarren/selene/blob/main/docs/src/SUMMARY.md
Comment on lines
+329
to
330
| roblox_manual_fromscale_or_fromoffset: lints::roblox_manual_fromscale_or_fromoffset::ManualFromScaleOrFromOffsetLint, | ||
| roblox_incorrect_color3_new_bounds: lints::roblox_incorrect_color3_new_bounds::Color3BoundsLint, |
There was a problem hiding this comment.
nit: this should be alphabetical order. Same with lints.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common PR comment and one that reduces readability. A selene lint to check for this usage will speed up development.